test: group poa admin #62
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #62 +/- ##
==========================================
+ Coverage 71.96% 72.31% +0.34%
==========================================
Files 32 33 +1
Lines 1737 1795 +58
==========================================
+ Hits 1250 1298 +48
- Misses 427 432 +5
- Partials 60 65 +5 ☔ View full report in Codecov by Sentry. |
| return exec(ctx, chain, config, chain.GetNode().TxCommand(accAddr, execCommand...)) | ||
| } | ||
|
|
||
| func exec(ctx context.Context, chain *cosmos.CosmosChain, config *ibc.ChainConfig, command []string) (string, error) { |
There was a problem hiding this comment.
This is essentially a wrapper around chainnode.ExecTx()
note to self for upstream: use a pattern which allows us to inject logic on a queried CosmosTx{} type. This way we can extend it's usage more, specifically for Group right away. Same for POA
There was a problem hiding this comment.
Absolutely, BUT chainnode.ExecTx() doesn't handle config.Env which I need.
| @@ -0,0 +1,735 @@ | |||
| package interchaintest | |||
There was a problem hiding this comment.
Make ictest-group-poa is not in the .github/workflows/e2e.yml file
|
I'll re-run CI tomorrow, the test is failing because we reached the maximum number of Docker requests. |
Add Group Proposal tests for when POA is a group address (group admin is the group policy itself).
Test
This PR is becoming huge so I want to get those merged. We can add more tests later.
Fixes #61