-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Input-Validation #9
base: main
Are you sure you want to change the base?
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 117
Lines ? 6846
Branches ? 0
========================================
Hits ? 6846
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Joseph Chalabi <[email protected]>
Signed-off-by: Joseph Chalabi <[email protected]>
test: more tests and refactor
fix: denom can be null
Redesign
Description
Added Formik & Yup for input Validation including additional tests for new input components.
Action Items
Finish Validation