Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize: Various version bumps for Seven Things #3

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

farmdawgnation
Copy link
Member

While preparing a talk on Lift I noticed that the Seven Things site could use some version bumps. So I went in and made some changes. There are a few things that are outstanding here. Specifically:

  • The tests don't seem to pass. They don't seem particularly useful? Should we chuck them or...?
  • I upgraded sbt since 0.11 won't run on Java 8 which more and more people are going to be switching to. We still have the old sbt-launch.jar in the repo but I'd like of like to nuke it altogether. Homebrew builds for sbt have gotten more reliable in recent days. Is there any value to having it?

@d6y
Copy link
Member

d6y commented Apr 19, 2015

Also: RunWebApp doesn't compile for me (but here's a version that does).

The XmlSourceSpecs.scala test: checking that the .html files are XML valid made a lot of sense pre-HTML. But now that we're using the HTML5 parser, less so. I suppose we could make the 27 failing .html files XML valid, but I don't think it's worth the effort. Better effort would be a HTMl5 validator. (It's OK -- I'm not suggesting adding one in this PR!)

@Shadowfiend
Copy link
Member

Fun fact, the validator might be pretty straightforward with the HTML5 parser we have and the ErrorReportingTokenizer.

@farmdawgnation
Copy link
Member Author

Why do we have specs running that check in this project anyway?

@Shadowfiend
Copy link
Member

Whelp, just noticed this PR again. Right on time! <_<

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants