Unpin scipy #198
Merged
Unpin scipy #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The issue in the CI does not originate from scipy, but instead from incompatibility of tensorflow probability to numpy 2.0. At first, I could not reproduce the issue locally, because locally, I installed using the The current solution is to pin numpy in liesel to <2.0, too, until the downstream issue is addressed. There's already an issue in the tensorflow probability repo: Once this is addressed, we can unpin numpy, since pymc correctly handles its dependency on numpy itself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cannot reproduce the issue reported in #185, so this PR simply removes the pin to scipy<=1.12.
Closes #185
Opened as a draft to see if our CI passes.