Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update optim #196

Merged
merged 18 commits into from
Sep 7, 2024
Merged

Update optim #196

merged 18 commits into from
Sep 7, 2024

Conversation

jobrachem
Copy link
Contributor

Closes #194

The changes are:

  1. The function now includes a progress bar
  2. The function now avoids including the model state into the compiled functions

Should avoid including model state in the compilation, hopefully leading to more memory-efficient code.
@jobrachem jobrachem added the comp:goose This issue is related to the goose module label Jul 24, 2024
@jobrachem jobrachem self-assigned this Jul 24, 2024
Improves compatibility to different optimizers from optax
@jobrachem jobrachem marked this pull request as draft August 12, 2024 15:04
@jobrachem jobrachem marked this pull request as ready for review August 13, 2024 14:39
@jobrachem
Copy link
Contributor Author

@GianmarcoCallegher yesterday, I found some more issues, so I converted the PR back to a draft and fixed them. It is now ready for review. The issues concerned:

  1. The implementation of early stopping contained a thinko. I had compared the current loss to the best loss within the patience periord. Now I compared the oldest loss in the patience period to the best loss within the patience period.
  2. The iteration counter and index handling was off by one. Now, iteration 0 refers to the initial values. Previously it referred to the values after the first update.

@GianmarcoCallegher
Copy link
Contributor

@jobrachem I saw new commits. Is it ready for the review?

@jobrachem
Copy link
Contributor Author

@GianmarcoCallegher Yes :)

@GianmarcoCallegher
Copy link
Contributor

Well done 😄

@GianmarcoCallegher GianmarcoCallegher merged commit 162ec0d into main Sep 7, 2024
4 checks passed
@GianmarcoCallegher GianmarcoCallegher deleted the update-optim branch September 7, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:goose This issue is related to the goose module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update optim_flat with local changes
2 participants