Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdrom: fix 'no track 1' edge case #325

Merged
merged 1 commit into from
Dec 31, 2023
Merged

cdrom: fix 'no track 1' edge case #325

merged 1 commit into from
Dec 31, 2023

Conversation

twolife
Copy link
Contributor

@twolife twolife commented Dec 31, 2023

unless I'm missing something obvious, c is never equal to zero

@sezero sezero requested a review from icculus December 31, 2023 14:11
@icculus
Copy link
Collaborator

icculus commented Dec 31, 2023

Yeah, you're right, this is a leftover from when the tracks started at zero, I think.

@icculus icculus merged commit c810b6a into libsdl-org:main Dec 31, 2023
5 checks passed
@sezero
Copy link
Contributor

sezero commented Dec 31, 2023

Issue was introduced in ed299ba
(original check was if (!rw && c > 1) )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icculus icculus Awaiting requested review from icculus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@twolife @icculus @sezero