Commits on Sep 13, 2023

1. Avoid SDL_GetMouseState(), which returns raw coordinates …

   sdl12-compat tracks the mouse position in the MousePosition variable,
   even when we're not in relative mouse mode. We therefore don't need to
   call SDL20_GetMouseState() to update it before entering relative mouse
   mode: we already have it from the last SDL_MOUSEMOTION event, and have
   already applied any scaling we need.
   
   This is important, because SDL_GetMouseState() returns the _raw_ mouse
   coordinates, not the ones scaled by SDL_RenderSetLogicalSize(). So we
   end up with a mismatch. This results in a mouse offset on non-OpenGL,
   scaled games, like Alpha Centauri in fullscreen (see libsdl-org#318).
   
   We could fix this by calling SDL_RenderWindowToLogical() instead, but
   that complicates the codepath as we don't always have an SDL_Renderer
   (we might be using OpenGL), so this seems cleaner.
   
   I've tested this with SMAC (where it fixes the bug) and Wolf4SDL (which
   was cited in the commit which introduced this check). Both work fine.

   

   sulix committed Sep 13, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 1413ab5
   • Browse repository at this point

   Copy the full SHA

   1413ab5 View commit details

   Browse the repository at this point in the history