Always fill *buf

It is an out parameter and callers might be tempted to free it no matter what the main return value says.
libsdl-org · Aug 6, 2023 · 9150989 · 9150989
1 parent 041cf9a
commit 9150989
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/SDL12_compat.c b/src/SDL12_compat.c
@@ -8454,12 +8454,12 @@ SDL_LoadWAV_RW(SDL12_RWops *rwops12, int freerwops12,
     SDL_RWops *rwops20 = RWops12to20(rwops12);
     SDL_AudioSpec *retval = NULL;
 
+    *buf = NULL;
+
     if (!rwops20) {
         return NULL;
     }
 
-    *buf = NULL;
-
     /* SDL2's LoadWAV requires a seekable stream, but SDL 1.2 didn't,
        so if the stream appears unseekable, try to load it into a
        memory rwops that we _can_ seek in */