Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building kmsdrm without crtswitchres #15408

Merged

Conversation

schellingb
Copy link
Contributor

Description

I build for my Raspberry Pi (which runs Linux not Lakka) with KMSDRM (-DHAVE_KMS -DHAVE_DRM -DHAVE_PLAIN_DRM) but without crt-switchres (no -DHAVE_CRTSWITCHRES).

I think since #15131 the build fails like that but I haven't noticed it because I don't update the build on the Pi that often.

This PR adds an #ifdef HAVE_CRTSWITCHRES guard around the crtswitchres using code in drm_ctx.c and makes RetroArch work again in my environment.

Related Issues

Related Pull Requests

Reviewers

Maybe @substring who contributed the KMS modeswitching for CRT?

@LibretroAdmin LibretroAdmin merged commit fa44384 into libretro:master Jun 19, 2023
21 checks passed
@substring
Copy link
Contributor

wooopsie I'll be more careful in the future!

@schellingb
Copy link
Contributor Author

@substring Hey no worries!!! The insane amount of environments RetroArch can run on this is impossible to avoid from time to time. Automated builds can only cover so many configurations. I think most of the time both things are enabled so it probably didn't cause much of an issue (it certainly didn't break Lakka or anything). On the contrary it being able to be fixed with a 1 line code change is a good thing I think :-) That is unless always returning false from gfx_ctx_drm_get_mode_from_video_state is not correct... I really have no idea about how this works, haha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants