Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leddialog: add brightness to solid led settings #797

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kyokenn
Copy link
Contributor

@kyokenn kyokenn commented Oct 13, 2022

Fixes #776

@staticssleever668
Copy link
Member

While the change itself is good, I don't think we should merge this right now as we would need some changes to libratbag.
One issue is that we would need an analogous change to ratbagctl, which probably won't be hard.
The bigger issue is that we don't support brightness on solid colors on the driver side. As far as I see, this is only supported in asus, sinowealth, test drivers. Because of this having such slider would be very confusing (at least for the time being).

@FFY00
Copy link
Member

FFY00 commented Mar 10, 2023

The bigger issue is that we don't support brightness on solid colors on the driver side.

This is generally implemented as the black component of the color, because you obviously can't have black light.

I had a look, and it seems that asus is the only driver from that list that actually sends both brightness and rgb values to the device. It'd be interesting to see what the device does with the black component of the color, and when the color is black.

I think that's a special case anyway, we should be able to implement this without any protocol changes, by just using the black component of the color as the brightness. IMO, we should also remove the brightness field from the C struct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce Brightness on Solid colors
3 participants