Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multidim-interop: Prune older versions #233

Merged
merged 2 commits into from
Jul 14, 2023
Merged

Conversation

MarcoPolo
Copy link
Contributor

We need to clean up older versions because we're getting close to the GHA limit: #229. Zig-libp2p, for example, already fails to build these tests because we run out of space.

js-libp2p is especially heavy since it includes the browsers. The older go-libp2p versions didn't create minimal images, so those are also heavier than they need to be.

I think it's safe to remove these since:

  1. They've been interop tested for a while now, unlikely to find anything new.
  2. While it's possible new versions slowly break compatibility with older versions, I feel like it's unlikely without also breaking a less old version (i.e. transitively testing). It's not guaranteed, but I think it's an okay tradeoff.

@MarcoPolo
Copy link
Contributor Author

Builds are already failing without this, so I'm going to merge this for now to unblock this repo and other repose as well.

@MarcoPolo MarcoPolo merged commit 1ebb8b5 into master Jul 14, 2023
1 of 2 checks passed
@MarcoPolo MarcoPolo deleted the marco/prune-older-versions branch July 14, 2023 21:01
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants