Skip to content

Commit

Permalink
Revert "Install playwright in the base image so it is cached (#226)" (#…
Browse files Browse the repository at this point in the history
…231)

* Revert "Install playwright in the base image so it is cached (#226)"

This reverts commit d21d042.

* Add comment
  • Loading branch information
MarcoPolo authored Jul 14, 2023
1 parent e69e155 commit 4bd0f99
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
4 changes: 4 additions & 0 deletions multidim-interop/impl/js/v0.45/BrowserDockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ FROM mcr.microsoft.com/playwright

COPY --from=js-libp2p-base /app/ /app/
WORKDIR /app/interop
# We install browsers here instead of the cached version so that we use the latest browsers at run time.
# Ideally this would also be pinned, but playwright controls this, so there isn't much we can do about it.
# By installing here, we avoid installing it at test time.
RUN ./node_modules/.bin/playwright install
ARG BROWSER=chromium # Options: chromium, firefox, webkit
ENV BROWSER=$BROWSER

Expand Down
1 change: 0 additions & 1 deletion multidim-interop/impl/js/v0.45/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,5 @@ RUN npm i && npm run build

WORKDIR /app/interop
RUN npm i && npm run build
RUN ./node_modules/.bin/playwright install

ENTRYPOINT [ "npm", "test", "--", "--build", "false", "--types", "false", "-t", "node" ]

0 comments on commit 4bd0f99

Please sign in to comment.