fix: deadlock on panic in transport testsuite #2934
+8
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jorropo
force-pushed
the
fix-deadlock-on-panic
branch
from
7d6a2fc
to
d9247c2
Compare
I had a panic in `list.Multiaddr()` which would deadlock the test instead of properly showing up the stack trace. This happens because in the defer block it waits for <-done however because the test never proceed the other goroutine is stuck on `.Accept()`, never sending `close(done)`.
sukunrt
force-pushed
the
fix-deadlock-on-panic
branch
from
d9247c2
to
cf1e554
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a panic in
list.Multiaddr()which would deadlock the test instead of properly showing up the stack trace.This happens because in the defer block it waits for <-done however because the test never proceed the other goroutine is stuck on
.Accept(), never sendingclose(done).