Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch containers to use Ubuntu noble #134

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Switch containers to use Ubuntu noble #134

merged 3 commits into from
Sep 10, 2024

Conversation

chantra
Copy link
Collaborator

@chantra chantra commented Aug 21, 2024

This contains a couple of steps:

  1. Add the possibility to override on a per runner basis the value of DOCKER_TAG by setting its value in /etc/action-runner/runner_unit-\d\d.env
  2. make the containers advertise a new docker-{distro}-main instead of docker-main . Current actions are looking for tag docker-main, so by using this new value, the containers won't be picked up
  3. change the value of DOCKER_TAG in /etc/action-runner/runner_unit.env This will make ALL container pick the ubuntu noble container version, and should be deployed only once all actions are running on ubuntu noble.

@chantra
ansible: Allow loading per-runner environment file
8bd67c1 
This allows overriding runners's DOCKER_TAG per instance. This is used
to transition individual runners to use the new noble image.

For instance, I transitioned runner 00 to use `main-noble-{arch}` by
running:
```
ansible -i ~/inventory.yml \
  aarch64 \
  -b  -m shell \
  -a 'echo DOCKER_TAG=main-noble-aarch64 > /etc/actions-runner/runner_unit-00.env'
```

Signed-off-by: Manu Bretelle <[email protected]>
@chantra
ansible: Make containers advertise "docker-noble-main" tag
adc2ad2 
This tag is used to transition containers to run Ubuntu noble.
Mind that currently, the container actually pulled will still be focal
until either DOCKER_TAG is changed to "main-noble-{arch}", or DOCKER_TAG
is overridden in the relevant `/etc/actions-runner/runner_unit-\d\d.env`
file.

Signed-off-by: Manu Bretelle <[email protected]>
@chantra
ansible: Switch containers to pull main-noble-{arch} container
b796dc7 
Signed-off-by: Manu Bretelle <[email protected]>
@chantra chantra marked this pull request as draft August 21, 2024 03:41
@chantra chantra marked this pull request as ready for review September 10, 2024 02:14
@chantra
Copy link
Collaborator Author

chantra commented Sep 10, 2024

This has been pushed to prod a while now. I am landing this to be able to fully retire old setup.

@chantra chantra merged commit 4b5c034 into libbpf:main Sep 10, 2024
2 checks passed
@chantra chantra deleted the ansible_intro_noble branch September 10, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@chantra