Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler warnings in Zephyr and FlexPRET support files #479

Merged
merged 9 commits into from
Sep 22, 2024

Conversation

erlingrj
Copy link
Collaborator

See title.

@erlingrj
Copy link
Collaborator Author

This PR addresses some new compiler warnings that arose when we changed the FlexPRET compiler. It triggered me to change a little the atomics API. I removed the functions explicitly targeting int32_t. Because it is used on many variables which are of type int and then they need to be casted. What is really needed is to have an atomics API capable of modifying 64bit values.

There is a test failure on FlexPRET, this is because reactor-c CI is referring to the CI jobs in master of lingua-franca, which is outdated. It will pass when we merge: lf-lang/lingua-franca#2405

Copy link
Contributor

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me. I added three questions.

low_level_platform/impl/src/lf_atomic_gcc_clang.c Outdated Show resolved Hide resolved
low_level_platform/impl/src/lf_atomic_gcc_clang.c Outdated Show resolved Hide resolved
low_level_platform/impl/src/lf_atomic_gcc_clang.c Outdated Show resolved Hide resolved
@erlingrj
Copy link
Collaborator Author

@edwardalee thanks for the review, sloppy of me to overlook the missing int32 -> int update. It is done now and I did a final self-review. Will merge when issues with the corresponding PR in lingua-franca is solved.

@lhstrh lhstrh merged commit e0eae5f into main Sep 22, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants