-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compiler warnings in Zephyr and FlexPRET support files #479
Conversation
This PR addresses some new compiler warnings that arose when we changed the FlexPRET compiler. It triggered me to change a little the atomics API. I removed the functions explicitly targeting int32_t. Because it is used on many variables which are of type There is a test failure on FlexPRET, this is because reactor-c CI is referring to the CI jobs in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me. I added three questions.
@edwardalee thanks for the review, sloppy of me to overlook the missing int32 -> int update. It is done now and I did a final self-review. Will merge when issues with the corresponding PR in |
See title.