Adjustments to launch script to handle SIGINT properly
#2143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardalee
reviewed
Dec 23, 2023
core/src/main/java/org/lflang/federated/launcher/FedLauncherGenerator.java
Outdated
Show resolved
Hide resolved
lhstrh
changed the title
SIGINT properly
lhstrh
force-pushed
the
federated-cleanup
branch
2 times, most recently
from
a7a51f2
to
e4c6c8b
Compare
petervdonovan
approved these changes
Jan 9, 2024
There was a problem hiding this comment.
Tentatively this looks OK, and I approve merging it, but this bash script has been through so many iterations, without necessarily monotonically decreasing bugginess, that I'm not sure I trust my own judgment anymore. I do not have a particularly strong mastery of advanced bash scripting techniques, and at some point it is possible that we should just throw up our hands and port it to Python.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of these changes is to make a federated program respond correctly to Ctrl-C, which it currently does not.