Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the checkstyle plugin for gradle using the google style template.
As it turns out, the checkstyle tool isn't quite the tool that I was after when I wrote #1806. Checkstyle is purely a style checker and it is quite pedantic 😅. For instance, these are the warnings produced for
TimeValue.java
:I think this is really nice to enforce a more consistent style, but I do think that we have more pressing problems at the moment than fixing all those style warnings. Therefore, I think we shouldn't merge this PR for now. I put the PR here in hope that it will be useful at a later point.
I will open another PR that uses the spotbugs tool, which is a static code analysis tool and produces much more useful warnings. (#2005)