Added strict mode.

lextudio · Mar 5, 2024 · b67f586 · b67f586
1 parent 4f82b27
commit b67f586
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/pysmi/codegen/intermediate.py b/pysmi/codegen/intermediate.py
@@ -74,6 +74,7 @@ class IntermediateCodeGen(AbstractCodeGen):
 
     indent = " " * 4
     fakeidx = 1000  # starting index for fake symbols
+    strictCompliance = True
 
     def __init__(self):
         self._rows = set()
@@ -180,9 +181,10 @@ def regSym(
 
             if moduleIdentity:
                 if self._moduleIdentityOid:
-                    # TODO: maybe we should show a warning here
-                    # raise error.PySmiSemanticError("Duplicate module identity")
-                    pass
+                    if self.strictCompliance:
+                        raise error.PySmiSemanticError("Duplicate module identity")
+                    else:
+                        pass
                 else:
                     self._moduleIdentityOid = outDict["oid"]
 

diff --git a/pysmi/scripts/mibdump.py b/pysmi/scripts/mibdump.py
@@ -37,6 +37,7 @@ def start():
 
     # Defaults
     verboseFlag = True
+    strictFlag = False
     mibSources = []
     doFuzzyMatchingFlag = True
     mibSearchers = []
@@ -60,6 +61,7 @@ def start():
     Usage: {} [--help]
         [--version]
         [--quiet]
+        [--strict]
         [--debug=<{}>]
         [--mib-source=<URI>]
         [--mib-searcher=<PATH|PACKAGE>]
@@ -97,6 +99,7 @@ def start():
                 "help",
                 "version",
                 "quiet",
+                "strict",
                 "debug=",
                 "mib-source=",
                 "mib-searcher=",
@@ -157,6 +160,9 @@ def start():
         if opt[0] == "--quiet":
             verboseFlag = False
 
+        if opt[0] == "--strict":
+            strictFlag = True
+
         if opt[0] == "--debug":
             debug.setLogger(debug.Debug(*opt[1].split(",")))
 
@@ -294,6 +300,7 @@ def start():
         searchers.append(StubSearcher(*mibStubs))
 
         codeGenerator = PySnmpCodeGen()
+        codeGenerator.strictCompliance = strictFlag
 
         fileWriter = PyFileWriter(dstDirectory).setOptions(
             pyCompile=pyCompileFlag, pyOptimizationLevel=pyOptimizationLevel
@@ -331,6 +338,7 @@ def start():
         ]
 
         codeGenerator = JsonCodeGen()
+        codeGenerator.strictCompliance = strictFlag
 
         fileWriter = FileWriter(dstDirectory).setOptions(suffix=".json")