Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade python, av, pyyaml, pillow, and numpy #60

Merged
merged 2 commits into from
May 29, 2024

Conversation

aentwist
Copy link
Contributor

@aentwist aentwist commented May 29, 2024

Minimum (first commit): fix av, min python from 3.7 to 3.8

More (second commit): max python from 3.10 to 3.12

  • We note that the max possible python version might have increased since the av-imposed 3.10 limit is removed
  • -> Try removing the max version
  • PySide6 wants max 3.12, so add that max (<3.13). This upgrades PySide6 in lockfile (minor versions, but the versioning is a little odd).
  • pyyaml, required by myst-parser, has a cython 3 issue with 6.0.0 that was patched in 6.0.1. Upgrade in lockfile to 6.0.1 (patch version).
  • pillow, required by adbutils, wants v10 for some reason. This upgrade spans a major version, I don't think we hit any breaking changes. See pillow 9->10 breaking changes to review. Maybe it has to do with the PySide6 upgrade, or (probably) the python one.
  • numpy also wants an upgrade. Upgrade in lockfile (minor versions).

After all this nonsense, pytest passes and poetry build works (on WSL Debian and Windows). The local scrcpy-client also works for my project where the one on pypi failed. No further testing has been done. Note that this was my first time ever using poetry. I do not see a project python version. First commit tested on python 3.10.14. Second commit tested on python 3.12.3 (current). Please feel free to test further however you usually might.

Closes #59

Upgrade av as versions 9 and 10 have Cython issues and do not build.

See leng-yue#59 (comment)

BREAKING CHANGE: av 11 and 12 both require Python >=3.8, so we
increase the minimum Python version from 3.7 to 3.8.
BREAKING CHANGE: drop support for pillow 9
@leng-yue leng-yue merged commit 0c6a506 into leng-yue:main May 29, 2024
1 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error: subprocess-exited-with-error when install python package
2 participants