Django 1.9 (WIP) #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 21, 2015 00:00
The generic_tag_compiler function was removed, as a part of a larger refactoring of the template library. For now, just pull in the definition of generic_tag_compiler from 1.8.
| from django.template.base import generic_tag_compiler, TagHelperNode, Template | ||
| try: | ||
| from django.template.base import generic_tag_compiler, TagHelperNode, Template | ||
| except ImportError: |
There was a problem hiding this comment.
It seems like this is a fine solution for now, but I think going forward unfortunately we're going to need a version check, and different code for each version with significant changes. In particular, backporting any changes when we're already trying to merge different versions of the code seems like it's just an impossible mess.
Also, I think it's probably better to do an explicit version check instead of try/except?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.