feat: add bns v2 client and zonefile request #615
Merged
+142
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alter-eggo
commented
Nov 12, 2024
| const network = useLeatherNetwork(); | ||
| const basePath = whenNetwork(bitcoinNetworkModeToCoreNetworkMode(network.chain.bitcoin.mode))({ | ||
| mainnet: BNS_V2_API_BASE_URL, | ||
| testnet: BNS_V2_API_BASE_URL, |
There was a problem hiding this comment.
not sure though if there will be testnet
alter-eggo
force-pushed
the
feat/bns-v2-zonefile
branch
from
0363870
to
4fd6f9a
Compare
alter-eggo
force-pushed
the
feat/bns-v2-zonefile
branch
from
4fd6f9a
to
0814345
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #615 +/- ##
==========================================
- Coverage 24.07% 23.84% -0.24%
==========================================
Files 164 165 +1
Lines 6085 6148 +63
Branches 333 335 +2
==========================================
+ Hits 1465 1466 +1
- Misses 4620 4682 +62
|
fbwoolf
approved these changes
Nov 12, 2024
kyranjamie
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds bns v2 client and zonefile request