Feat/approver ux UI #609
Feat/approver ux UI #609
Conversation
| import { AdvancedDetailsButton } from './components/advanced-details-button'; | ||
| import { AccountCard } from './components/cards/account-card'; | ||
| import { CodeCard } from './components/cards/code-card'; | ||
| import { FeeCard } from './components/cards/fee-card'; | ||
| import { InputsAndOutputsCard } from './components/cards/inputs-outputs-card'; | ||
| import { OutcomesCard } from './components/cards/outcomes-card'; | ||
| import { Footer } from './components/footer'; |
There was a problem hiding this comment.
The core styles for approver ux should be in UI package src/components/approver.
Also approver should not be "aware" of any details like fees/inputs etc. signPsbt should be an instance of <Approver />
| import { InputsAndOutputsCard } from './components/cards/inputs-outputs-card'; | ||
| import { OutcomesCard } from './components/cards/outcomes-card'; | ||
|
|
||
| export function Approver({ children }: HasChildren) { |
There was a problem hiding this comment.
Can we colocate this in packages/ui/src/components/approver though, or are you just working in mobile first and will migrate later for ease of dev?
There was a problem hiding this comment.
for example, I think we can even reuse the same approver context for both implementations? As there's no platform specific behaviour inside (at least there shouldn't be)
There was a problem hiding this comment.
Yeap i've been keeping it here for a faster development. Planning to move it to ui once done
No description provided.