fix: do not dismount inscription content from view #5964
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyranjamie
requested review from
pete-watters,
fbwoolf and
brandonmarshall-tm
kyranjamie
force-pushed
the
fix/trigger-in-view-once
branch
from
21efb89
to
f90937e
Compare
|
Tested, this looks and runs great! It does still un-load when switching accounts which I think is perfectly acceptable. Will definitely let you know if we get any complaints of sluggish behavior as a result of not removing from cache on scroll, but it's working great on my machine. |
brandonmarshall-tm
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@brandonmarshall-tm, re conversation yesterday. Once an inscriptions is rendered, we leave it rendered, even if scrolled out of the viewport.