chore: demo redundancy of recursive account balance lookup

[pete-watters]

In my investigations into account restore I found that:

• we run recurseAccountsForActivity however it never actually does any account creation
• all accounts are created at the start via a check for legacyAccountActivityLookup !== 0

I tested this with a few different wallets:

• my own (3 accounts)
• leather dev wallet
• other account with 400 wallets

Just opening this draft to demonstrate recurseAccountsForActivity is not working as we would expect.

[pete-watters]

The bug in this code seems to be that recursiveActivityIndex is actually returning the most recent account from checkForMostRecentAccount.

[pete-watters]

As legacyAccountActivityLookup !== 0 all accounts are created here on first load before recurseAccountsForActivity continues

[kyranjamie]

I don't see a problem here. With dev account, the promise does resolve.

In this instance, the legacy look up and the recursive look up are the same, so we call the restoreAccountIndex action later on . The extension works differently to the mobile wallet. We're not supposed to be generating accounts here. We just need to know—and save in the state—what the highest known account index is. With that information, the app elsewhere generates the accounts.

The fact that Gaia and the recursive look up have the same value is good, that means that it works. If you remove all the gaia look/legacy account look up code, and the condition on L105, then the recursive look up will set that value, and the wallet will generate.