Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: duplicate keys error #4796

Merged
merged 1 commit into from
Jan 11, 2024
Merged

fix: duplicate keys error #4796

merged 1 commit into from
Jan 11, 2024

Conversation

alter-eggo
Copy link
Contributor

@alter-eggo alter-eggo commented Jan 10, 2024 •
edited by github-actions bot
Loading

Try out this version of Leather — Extension build, Test report

Screenshot 2024-01-10 at 15 58 43

@kyranjamie
Copy link
Collaborator

Could a test catch the local runtime errors and fail in future?

kyranjamie
kyranjamie approved these changes Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@kyranjamie kyranjamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?? might be the more appropriate operator?

@alter-eggo
Copy link
Contributor Author

alter-eggo commented Jan 10, 2024 •
edited
Loading

Could a test catch the local runtime errors and fail in future?

hmm, seems yes https://stackoverflow.com/questions/73448785/how-to-detect-uncaught-in-promise-typeerror-in-playwright

@alter-eggo alter-eggo added this pull request to the merge queue Jan 11, 2024
Merged via the queue into dev with commit 77dc018 Jan 11, 2024
29 checks passed
@alter-eggo alter-eggo deleted the fix/duplicate-keys-error branch January 11, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pete-watters pete-watters pete-watters approved these changes

@kyranjamie kyranjamie kyranjamie approved these changes

@edgarkhanzadian edgarkhanzadian Awaiting requested review from edgarkhanzadian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alter-eggo @kyranjamie @pete-watters