Merge pull request #1245 from leather-wallet/fix/remove-windows-code-…

…signing chore: remove win code signing
leather-io · Oct 24, 2023 · 1dbef35 · 1dbef35
2 parents 754e4d6 + 7b8f883
commit 1dbef35
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 4 deletions.
diff --git a/.github/workflows/debug-build.yml b/.github/workflows/debug-build.yml
@@ -44,8 +44,6 @@ jobs:
           - os: windows-latest
             NPM_COMMAND: win
             UPLOAD_ASSETS: release/**/*.exe
-            CSC_LINK_SECRET_NAME: CODE_SIGNING_CERTIFICATE_WINDOWS
-            CSC_KEY_PASSWORD_SECRET_NAME: CODE_SIGNING_PASSWORD_WINDOWS
 
     steps:
       - name: Cancel Previous Runs
@@ -116,6 +114,7 @@ jobs:
         uses: Saionaro/[email protected]
 
       - name: Build releases
+        if: matrix.os == 'macos-11'
         run: ./node_modules/.bin/cross-env yarn package-${{ matrix.NPM_COMMAND }}
         env:
           DEBUG_PROD: true
@@ -130,6 +129,18 @@ jobs:
           APPLE_ID: ${{ secrets.APPLE_ID }}
           APPLE_ID_PASS: ${{ secrets.APPLE_ID_PASS }}
 
+      - name: Build releases
+        if: matrix.os != 'macos-11'
+        run: ./node_modules/.bin/cross-env yarn package-${{ matrix.NPM_COMMAND }}
+        env:
+          DEBUG_PROD: true
+          NODE_ENV: production
+          SHA: ${{ github.event.pull_request.head.sha }}
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          PULL_REQUEST: ${{ steps.vars.outputs.pull_request_id }}
+          BRANCH_NAME: ${{ steps.vars.outputs.branch_name }}
+          SENTRY_DSN: ${{ secrets.SENTRY_DSN }}
+
       - run: ls -R release
 
       - uses: actions/upload-artifact@v2

diff --git a/.github/workflows/publish-version.yml b/.github/workflows/publish-version.yml
@@ -32,8 +32,6 @@ jobs:
           - os: windows-latest
             NPM_COMMAND: win
             UPLOAD_ASSETS: release/**/*.exe
-            CSC_LINK_SECRET_NAME: CODE_SIGNING_CERTIFICATE_WINDOWS
-            CSC_KEY_PASSWORD_SECRET_NAME: CODE_SIGNING_PASSWORD_WINDOWS
 
     steps:
       - name: Cancel Previous Runs
@@ -87,6 +85,7 @@ jobs:
         if: matrix.os == 'windows-latest'
 
       - name: Build releases
+        if: matrix.os == 'macos-11'
         run: ./node_modules/.bin/cross-env yarn package-${{ matrix.NPM_COMMAND }}
         env:
           GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
@@ -98,6 +97,15 @@ jobs:
           APPLE_ID: ${{ secrets.APPLE_ID }}
           APPLE_ID_PASS: ${{ secrets.APPLE_ID_PASS }}
 
+      - name: Build releases
+        if: matrix.os != 'macos-11'
+        run: ./node_modules/.bin/cross-env yarn package-${{ matrix.NPM_COMMAND }}
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          NODE_ENV: production
+          SENTRY_DSN: ${{ secrets.SENTRY_DSN }}
+          SEGMENT_WRITE_KEY: ${{ secrets.SEGMENT_WRITE_KEY }}
+
       - uses: actions/upload-artifact@v2
         name: ${{ matrix.os }} upload
         with:

diff --git a/electron-builder.js b/electron-builder.js
@@ -43,6 +43,7 @@ const baseConfig = {
     ],
   },
   win: {
+    verifyUpdateCodeSignature: false,
     // Don't use `msi` installer issues
     target: [
       {