-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unsubscribe links and domain-only "From" email addresses #3721
Conversation
…nclude a plaintext version of emails
This is finally ready to be reviewed @kkbrum @milescalabresi! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The migrations and such look good. The template tag unsubscribe link works well at least when the token is valid. For the other forms, I'll have to test a bit more on dev5 when we test the stable release. For now, just one minor request clarifying the username.
Done! |
* Generate unsubscribe links and add unsubscribe headers to emails * Add separate view for oneclick POSTs; add unsubscribe confirmation button * Constrain "from" email address for comm panel * lint fixes * Fix regex * Make director email match domain/subdomain pattern * Add migration; fix regex * Fix tests * fix more tests * require that the from_email for send_mail matches our DMARC; always include a plaintext version of emails * lint fix * Add info@ PlainRedirect if it doesn't exist with migration * Misc fixes * lint fix * Include email in error message to help with debugging * Support named email addresses * Fix commpanel test * Add username
* Generate unsubscribe links and add unsubscribe headers to emails * Add separate view for oneclick POSTs; add unsubscribe confirmation button * Constrain "from" email address for comm panel * lint fixes * Fix regex * Make director email match domain/subdomain pattern * Add migration; fix regex * Fix tests * fix more tests * require that the from_email for send_mail matches our DMARC; always include a plaintext version of emails * lint fix * Add info@ PlainRedirect if it doesn't exist with migration * Misc fixes * lint fix * Include email in error message to help with debugging * Support named email addresses * Fix commpanel test * Add username
* Generate unsubscribe links and add unsubscribe headers to emails * Add separate view for oneclick POSTs; add unsubscribe confirmation button * Constrain "from" email address for comm panel * lint fixes * Fix regex * Make director email match domain/subdomain pattern * Add migration; fix regex * Fix tests * fix more tests * require that the from_email for send_mail matches our DMARC; always include a plaintext version of emails * lint fix * Add info@ PlainRedirect if it doesn't exist with migration * Misc fixes * lint fix * Include email in error message to help with debugging * Support named email addresses * Fix commpanel test * Add username
* Generate unsubscribe links and add unsubscribe headers to emails * Add separate view for oneclick POSTs; add unsubscribe confirmation button * Constrain "from" email address for comm panel * lint fixes * Fix regex * Make director email match domain/subdomain pattern * Add migration; fix regex * Fix tests * fix more tests * require that the from_email for send_mail matches our DMARC; always include a plaintext version of emails * lint fix * Add info@ PlainRedirect if it doesn't exist with migration * Misc fixes * lint fix * Include email in error message to help with debugging * Support named email addresses * Fix commpanel test * Add username
This does the following:
send_mail()
also requires that the "from_email" matches these constraints and throws an error if this is not the case (just in case it somehow got through the above restrictions).Fixes #1719 and fixes #3709 and fixes #1094.