Skip to content
This repository has been archived by the owner on Aug 6, 2024. It is now read-only.

chore: add Dark mode + some rewrites #248

Merged
merged 31 commits into from
Apr 26, 2024
Merged

chore: add Dark mode + some rewrites #248

merged 31 commits into from
Apr 26, 2024

Conversation

koen1711
Copy link
Member

No description provided.

@koen1711 koen1711 requested a review from a team as a code owner April 23, 2024 08:40
@koen1711
Copy link
Member Author

Not ready yet

github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 24, 2024
View reviewed changes
src/app/effects/app.effects.ts Fixed Show fixed Hide fixed
src/app/effects/app.effects.ts Fixed Show fixed Hide fixed
@koen1711 koen1711 requested a review from sverben April 24, 2024 09:33
@koen1711
Copy link
Member Author

Ready for review

@sverben
Copy link
Member

sverben commented Apr 24, 2024

image
oops?

@sverben
Copy link
Member

sverben commented Apr 24, 2024

image
selection items in dark mode lack contrast

@sverben
Copy link
Member

sverben commented Apr 24, 2024

image
missed one

@sverben
Copy link
Member

sverben commented Apr 24, 2024

image
another

@sverben
Copy link
Member

sverben commented Apr 24, 2024

image
secondary selection

@koen1711 koen1711 changed the title chore: start on scss rewrite chore: add Dark mode + some rewrites Apr 24, 2024
@sverben
Copy link
Member

sverben commented Apr 24, 2024

image
the robot type background is missing

@koen1711
Copy link
Member Author

All fixed.

@koen1711 koen1711 requested a review from sverben April 24, 2024 21:58
@sverben
Copy link
Member

sverben commented Apr 24, 2024

image
what happen?

@sverben
Copy link
Member

sverben commented Apr 24, 2024

image
the background is in front of the blocks, so you cannot drag blocks behind it, it also overlays on the workspace

@sverben
Copy link
Member

sverben commented Apr 24, 2024

image
contrast please

@sverben
Copy link
Member

sverben commented Apr 24, 2024

image
something's up with the micropython file selector idk

@koen1711
Copy link
Member Author

image the background is in front of the blocks, so you cannot drag blocks behind it, it also overlays on the workspace

It is not possible to ever display both that and a background color, choose your lane.

@sverben
Copy link
Member

sverben commented Apr 25, 2024

image the background is in front of the blocks, so you cannot drag blocks behind it, it also overlays on the workspace

It is not possible to ever display both that and a background color, choose your lane.

Bs, make it transparent and change body background

sverben
sverben reviewed Apr 25, 2024
View reviewed changes
src/app/modules/components/header/header.component.scss Outdated
color: var(--leaphy-color-light) !important;
border-color: var(--leaphy-color-secundary) !important;
background-color: transparent;
border-color: var(--leaphy-color-secundary);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

border is no longer applying

@rmoesbergen
Copy link
Member

A few smaller things:
image
🤔

selected text in dropdown is too dark:
image

Focussed block text fields have a black background with dark text:
image

Hover/selection in python folder picker is black:
image

@koen1711
Copy link
Member Author

Waiting for @rmoesbergen his review.

@koen1711 koen1711 merged commit 68bb8d5 into main Apr 26, 2024
3 checks passed
@koen1711 koen1711 deleted the theme-rewrite branch April 26, 2024 08:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sverben sverben sverben approved these changes

@rmoesbergen rmoesbergen rmoesbergen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@koen1711 @sverben @rmoesbergen