Remove codeContractAddress from Enforcer, Verifier, implement EVMCode #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #137 +/- ##
=========================================
- Coverage 96.86% 93.7% -3.16%
=========================================
Files 7 7
Lines 1306 1303 -3
Branches 223 224 +1
=========================================
- Hits 1265 1221 -44
- Misses 16 57 +41
Partials 25 25
Continue to review full report at Codecov.
|
peara
changed the title
pinkiebell
added a commit
that referenced
this pull request
Jul 4, 2019
This includes a few changes to the original PR. Notably: - remove fragLength - fix that out of bounds code reads return zero(es) Also: - fix CODECOPY opcode as driveby (out of bounds reads are ZERO) and not an error
pinkiebell
added a commit
that referenced
this pull request
Jul 5, 2019
* Import first part of #137 This includes a few changes to the original PR. Notably: - remove fragLength - fix that out of bounds code reads return zero(es) Also: - fix CODECOPY opcode as driveby (out of bounds reads are ZERO) and not an error * pos >= self.length !
pinkiebell
reviewed
Jul 8, 2019
| @@ -32,6 +16,81 @@ module.exports = class Merkelizer extends AbstractMerkleTree { | |||
| return res; | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
Next partial PR I would say. We can extend AbstractMerkleTree and get a own class for a general 'word-sized'-merkle tree. So we can re-use this for calldata and so on 🙂
pinkiebell
added a commit
that referenced
this pull request
Jul 9, 2019
The `FragmentTree` does not follow orignal code hashing. A fragment leaf consists of `value`, `slot` and `byteLength`. `byteLength` is the orignal length of any given bytes.
pinkiebell
added a commit
that referenced
this pull request
Jul 11, 2019
pinkiebell
added a commit
that referenced
this pull request
Jul 11, 2019
pinkiebell
added a commit
that referenced
this pull request
Jul 11, 2019
pinkiebell
added a commit
that referenced
this pull request
Jul 13, 2019
pinkiebell
added a commit
that referenced
this pull request
Jul 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#117
Changes:
0xfeif not known.CODECOPYcodeContractAddresscodeContractAddresssubmitProofwill require codes with proofs. At most 2 Merkle proofs are need. 1 for the opcode at current pc. 1 for the data as inPUSHor for another opcode as inJUMP.run, revert if encounter unknown code.