[WIP] First draft #1
Conversation
setup.js
Outdated
| let slotId = 0; | ||
| for (let i = 0; i < nodes.length; i++) { | ||
| let node = nodes[i]; | ||
| const info = await node.web3.getValidatorInfo(); |
There was a problem hiding this comment.
This shouldn't be a part of our API, you can fetch it from tendermint directly
There was a problem hiding this comment.
But if we'll implement leapdao/leap-node#108 it can come in handy 🤔
There was a problem hiding this comment.
I think this is very useful. It basically allows us to say to the node: please identify yourself. We definitely need this for the ethereum address, so might as well add tendermint next to it no?
| // Wait for setup to propagate to all the nodes | ||
| await sleep(15000); | ||
|
|
||
| var testPath = require("path").join(__dirname, "tests"); |
There was a problem hiding this comment.
I have a really bad feeling about that. You basically just implemented test runner but without features. But there are tons of nice test runners (jest for example) that you can setup like that
There was a problem hiding this comment.
Noted and will be done, but closing this PR for now.
needs a bunch of minor changes to be complete