also test storage layout of implementation during upgrade (#122)

leapdao · Jan 25, 2019 · d97b62f · d97b62f
1 parent eec6444
commit d97b62f
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/contracts/mocks/BridgeMock.sol b/contracts/mocks/BridgeMock.sol
@@ -12,8 +12,13 @@ import "../Adminable.sol";
 
 contract BridgeMock is Adminable {
   address public operator;
+  uint256 public value;
 
   function setOperator(address _operator) public ifAdmin {
     operator = _operator;
   }
+
+  function setValue(uint256 _value) public {
+    value = _value;
+  }
 }
diff --git a/test/minGov.js b/test/minGov.js
@@ -125,6 +125,9 @@ contract('MinGov', (accounts) => {
   });
 
   it('should allow to upgrade bridge', async () => {
+    const someVal = 1234;
+    // set storage befor upgrade
+    await bridge.setValue(someVal);
     // deploy new contract
     const proxy = await AdminableProxy.at(bridge.address);
     const newBridgeLogic = await Bridge.new();
@@ -133,11 +136,15 @@ contract('MinGov', (accounts) => {
     const data = await proxy.contract.methods.upgradeTo(newBridgeLogic.address).encodeABI();
     await gov.propose(bridge.address, data);
     await gov.finalize();
+    const newBridge = await Bridge.at(proxy.address);
 
     // check value after
     const imp = '0x7050c9e0f4ca769c69bd3a8ef740bc37934f8e2c036e5a723fd8ee048ed3f8c3';
     const logicAddr = await web3.eth.getStorageAt(proxy.address, imp);
     assert.equal(logicAddr.toLowerCase(), newBridgeLogic.address.toLowerCase());
+    // check storage still matches
+    const val = await newBridge.value();
+    assert.equal(someVal, val.toNumber());
   });
 
   it('should allow to transfer into new governance', async () => {