-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fast exits #258
Open
troggy
wants to merge
10
commits into
master
Choose a base branch
from
fix/fast-exits
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix: fast exits #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test with:
|
MaxStalker
approved these changes
Nov 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Steps I took during review:
- Checked the code to my best ability and understanding
- Launched local version of bridge and initiated exit of 0.001 LEAP
- pendingFastExits in localStorage is populated with transaction and Unspent list also shows new status for that UTXO
- Succesfully exited 0.001 LEAP 🎉
Notes:
- there were some hiccups with bringing bridge-ui up locally on Windows machine
- I was able to get
CONFIG_NAME
populated, when I update webpack portion of val-loader rule to:
{
test: require.resolve('./src/config/env.js'),
use: [
{
loader: 'val-loader',
options: {
CONFIG_NAME: process.env.CONFIG,
},
},
],
},
and start:testnet
script in package.json
to:
"start:testnet": "set CONFIG=testnet && yarn start",
Though this is specific case for Windows. If we want to support this platform, I would recommend that we opt to use cross-env
module in the future
MaxStalker
approved these changes
Dec 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires leapdao/leap-core#164
Server-side of exit market maker had changed long time ago and bridge UI wasn't adapted yet. Addressing it here
Deployed on testnet.leapdao.org