Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fast exits #258

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

fix: fast exits #258

wants to merge 10 commits into from

Conversation

troggy
Copy link
Member

@troggy troggy commented Nov 24, 2019

Requires leapdao/leap-core#164

Server-side of exit market maker had changed long time ago and bridge UI wasn't adapted yet. Addressing it here

Deployed on testnet.leapdao.org

@troggy
Copy link
Member Author

troggy commented Nov 26, 2019

Test with:

# in leap-core
git checkout feat/fast-exit-return-signed-transfer
yarn
yarn link

# in bridge-ui
git checkout fix/fast-exits
yarn
yarn link leap-core
CONFIG=testnet yarn start

Copy link
Member

@MaxStalker MaxStalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Steps I took during review:

  • Checked the code to my best ability and understanding
  • Launched local version of bridge and initiated exit of 0.001 LEAP
  • pendingFastExits in localStorage is populated with transaction and Unspent list also shows new status for that UTXO
  • Succesfully exited 0.001 LEAP 🎉

Notes:

  • there were some hiccups with bringing bridge-ui up locally on Windows machine
  • I was able to get CONFIG_NAME populated, when I update webpack portion of val-loader rule to:
      {
        test: require.resolve('./src/config/env.js'),
        use: [
          {
            loader: 'val-loader',
            options: {
              CONFIG_NAME: process.env.CONFIG,
            },
          },
        ],
      },

and start:testnet script in package.json to:

    "start:testnet": "set CONFIG=testnet && yarn start",

Though this is specific case for Windows. If we want to support this platform, I would recommend that we opt to use cross-env module in the future

@troggy troggy self-assigned this Apr 24, 2020
@troggy troggy removed their assignment Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants