-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(Algebra/Ring/Ext): prove extensionality lemmas for Ring and similar typeclasses #9511
Commits on Jan 5, 2024
-
feat(Algebra/Ring/Ext): start writing ext lemmas for rings
This is based on discussion in the Zulip thread https://leanprover.zulipchat.com/stream/287929-mathlib4/topic/Ring.20is.20determined.20by.20Semiring. Note that this commit introduce `sorry`s into the codebase. It is a WIP.
Configuration menu - View commit details
-
Copy full SHA for 294d9c6 - Browse repository at this point
Copy the full SHA 294d9c6View commit details
Commits on Jan 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 432b6c0 - Browse repository at this point
Copy the full SHA 432b6c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for a9f6a29 - Browse repository at this point
Copy the full SHA a9f6a29View commit details -
feat(Algebra/Ring/Ext): prove extensionality lemmas for
Semiring
Prove `Semiring.ext` and `Semiring.ext_iff` lemmas, as well as that `Semiring.toNonUnitalSemiring` and `Semiring.toNonAssocSemiring` are injective.
Configuration menu - View commit details
-
Copy full SHA for a849abc - Browse repository at this point
Copy the full SHA a849abcView commit details -
refactor(Algebra/Ring/Ext): restructure ext lemmas for
Semiring
Prove the injectivity lemma in terms of the `ext` lemma, as the former goes through showing that `h_add` and `h_mul` hold anyway.
Configuration menu - View commit details
-
Copy full SHA for 0182195 - Browse repository at this point
Copy the full SHA 0182195View commit details -
Configuration menu - View commit details
-
Copy full SHA for a9d2b96 - Browse repository at this point
Copy the full SHA a9d2b96View commit details -
feat(Algebra/Ring/Ext): add injectivity lemma for
NonAssocSemiring
Prove that `NonAssocSemiring.toNonUnitalNonAssocSemiring` is injective.
Configuration menu - View commit details
-
Copy full SHA for c6683f4 - Browse repository at this point
Copy the full SHA c6683f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 60dc1a1 - Browse repository at this point
Copy the full SHA 60dc1a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 200fc5c - Browse repository at this point
Copy the full SHA 200fc5cView commit details -
feat(Algebra/Ring/Ext): prove ext lemmas for
NonUnitalNonAssocRing
Prove an `ext` lemma and use it to show that `NonUnitalNonAssocRing.toNonUnitalNonAssocSemiring` is injective as well as an `ext_iff` lemma.
Configuration menu - View commit details
-
Copy full SHA for c99d235 - Browse repository at this point
Copy the full SHA c99d235View commit details -
feat(Algebra/Ring/Ext): add injectivity lemma for `NonUnitalNonAssocS…
…emiring` Show that `NonUnitalNonAssocSemiring.toDistrib` is injective.
Configuration menu - View commit details
-
Copy full SHA for c138be4 - Browse repository at this point
Copy the full SHA c138be4View commit details -
style(Algebra/Ring/Ext): remove unused names, change
rcases
tocases
One exception: leave the `h` in `fun h ↦` in `ext_iff` proofs, for (marginally) more readability.
Configuration menu - View commit details
-
Copy full SHA for 505d31d - Browse repository at this point
Copy the full SHA 505d31dView commit details -
Configuration menu - View commit details
-
Copy full SHA for e32510d - Browse repository at this point
Copy the full SHA e32510dView commit details -
feat(Algebra/Ring/Ext): add injectivity lemma for
Semiring
Prove that `Semiring.toNonAssocSemiring` is injective.
Configuration menu - View commit details
-
Copy full SHA for 7a4fcce - Browse repository at this point
Copy the full SHA 7a4fcceView commit details -
feat(Algebra/Ring/Ext): start ext lemmas for {NonUnital,NonAssoc,}Ring
For each of the three typeclasses, state the `ext` lemma with a sorried proof and prove the consequences (injectivity and `ext_iff` lemmas).
Configuration menu - View commit details
-
Copy full SHA for db29b79 - Browse repository at this point
Copy the full SHA db29b79View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b40300 - Browse repository at this point
Copy the full SHA 4b40300View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6178024 - Browse repository at this point
Copy the full SHA 6178024View commit details -
style(Algebra/Ring/Ext): add some inline comments
Highlight the locations in the file where something mathematically non-trivial is proved: namely that some operation is determined by others. (There are essentially only two such.)
Configuration menu - View commit details
-
Copy full SHA for e5e5486 - Browse repository at this point
Copy the full SHA e5e5486View commit details -
Configuration menu - View commit details
-
Copy full SHA for 70282a3 - Browse repository at this point
Copy the full SHA 70282a3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b2249e - Browse repository at this point
Copy the full SHA 4b2249eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 993a7f3 - Browse repository at this point
Copy the full SHA 993a7f3View commit details
Commits on Jan 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c78ee2a - Browse repository at this point
Copy the full SHA c78ee2aView commit details -
style(Algebra/Ring/Ext): change variable names
Change `a`, `b` to `x`, `y` in accordance with https://leanprover-community.github.io/contribute/style.html#variable-conventions. Additionally, remove an unnecessary `'` from a variable `inst`.
Configuration menu - View commit details
-
Copy full SHA for 9412010 - Browse repository at this point
Copy the full SHA 9412010View commit details -
Configuration menu - View commit details
-
Copy full SHA for af0f907 - Browse repository at this point
Copy the full SHA af0f907View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d24100 - Browse repository at this point
Copy the full SHA 7d24100View commit details -
Configuration menu - View commit details
-
Copy full SHA for c36ab27 - Browse repository at this point
Copy the full SHA c36ab27View commit details -
Configuration menu - View commit details
-
Copy full SHA for 41329f7 - Browse repository at this point
Copy the full SHA 41329f7View commit details
Commits on Jan 9, 2024
-
doc(Algebra/Ring/Ext): fix copyright year
Realise that it is now 2024 :). Co-authored-by: Riccardo Brasca <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0b335dd - Browse repository at this point
Copy the full SHA 0b335ddView commit details -
doc(Algebra/Ring/Ext): fix typo
Fix typo in module header describing file. Co-authored-by: Eric Wieser <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2c5b5f8 - Browse repository at this point
Copy the full SHA 2c5b5f8View commit details
Commits on Feb 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b0a10f3 - Browse repository at this point
Copy the full SHA b0a10f3View commit details -
style(Algebra/Ring/Ext): change format for referring to other files
This is in accordance with the discussion in the thread #9511 (comment).
Configuration menu - View commit details
-
Copy full SHA for 10abca9 - Browse repository at this point
Copy the full SHA 10abca9View commit details -
feat(Algebra/Ring/Ext): extract some further extensionality lemmas
Leave the `Add(Comm)MonoidWithOne` and `Add(Comm)GroupWithOne` extensionality lemmas in `Mathlib/Algebra/Ring/Ext.lean` for now. This resolves comments #9511 (comment) and #9511 (comment).
Configuration menu - View commit details
-
Copy full SHA for 309b6ed - Browse repository at this point
Copy the full SHA 309b6edView commit details -
Configuration menu - View commit details
-
Copy full SHA for ce97567 - Browse repository at this point
Copy the full SHA ce97567View commit details
Commits on Apr 8, 2024
-
chore(Algebra/Ring/Ext): remove commented
import Mathlib
Co-authored-by: Anne Baanen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 50fa902 - Browse repository at this point
Copy the full SHA 50fa902View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6580ed5 - Browse repository at this point
Copy the full SHA 6580ed5View commit details -
refactor(Algebra/Ring/Ext): change macro to "point-free" style
WARNING: this commit is NOT error-free.
Configuration menu - View commit details
-
Copy full SHA for f081164 - Browse repository at this point
Copy the full SHA f081164View commit details -
refactor(Algebra/Ring/Ext): change
ext
lemma arguments to new styleWARNING: this commit is NOT error-free.
Configuration menu - View commit details
-
Copy full SHA for bddf5fa - Browse repository at this point
Copy the full SHA bddf5faView commit details -
refactor(Algebra/Ring/Ext): change
ext_iff
arguments to new styleWARNING: this commit is NOT error-free.
Configuration menu - View commit details
-
Copy full SHA for 6eca4f8 - Browse repository at this point
Copy the full SHA 6eca4f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for fbee3e7 - Browse repository at this point
Copy the full SHA fbee3e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 35b590c - Browse repository at this point
Copy the full SHA 35b590cView commit details
Commits on May 9, 2024
-
doc(Algebra/Ring/Ext): refactor comment about
AddMonoidWithOne
etc.Based on review suggestions https://github.com/leanprover-community/mathlib4/pull/9511/files#r1574231108, https://github.com/leanprover-community/mathlib4/pull/9511/files#r1574232858. Co-authored-by: Anne Baanen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8ceebd8 - Browse repository at this point
Copy the full SHA 8ceebd8View commit details -
Configuration menu - View commit details
-
Copy full SHA for d096e0b - Browse repository at this point
Copy the full SHA d096e0bView commit details -
fix(Algebra/Ring/Ext): fix error caused by upstream changes.
Specifically, replace `← Int.coe_nat_eq` with `Int.ofNat_eq_coe`.
Configuration menu - View commit details
-
Copy full SHA for d410631 - Browse repository at this point
Copy the full SHA d410631View commit details