Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adaptations for nightly-2024-10-30 #18435

Merged
merged 9 commits into from
Oct 31, 2024
Merged

Conversation

kim-em
Copy link
Contributor

@kim-em kim-em commented Oct 30, 2024

No description provided.

Copy link

PR summary 1686bee2eb

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Data.List.GroupBy 289 0 -289 (-100.00%)
Import changes for all files
Files Import difference
There are 4850 files with changed transitive imports taking up over 201493 characters: this is too many to display!
You can run scripts/import_trans_difference.sh all locally to see the whole output.

Declarations diff

+ ListBlank.cons_flatMap
+ ListBlank.flatMap
+ ListBlank.flatMap_mk
+ Perm.flatMap_left
+ _root_.FreeAddMonoid.ofList_join
+ append_flatten_map_append
+ bind_eq_flatMap
+ chain'_flatten
+ chain'_getLast_head_splitBy
+ chain'_of_mem_splitBy
+ countP_flatMap
+ countP_flatMap'
+ countP_flatten'
+ count_flatMap
+ count_flatMap'
+ count_flatten'
+ drop_sum_flatten
+ drop_sum_flatten'
+ drop_take_succ_flatten_eq_getElem
+ drop_take_succ_flatten_eq_getElem'
+ filterMap_eq_flatMap_toList
+ flatMap_append_perm
+ flatMap_congr
+ flatMap_pure_eq_map
+ flatten_drop_length_sub_one
+ flatten_groupBy
+ flatten_splitBy
+ flatten_splitWrtComposition
+ flatten_splitWrtCompositionAux
+ infix_flatMap_of_mem
+ instance : CommRing (BitVec w)
+ instance : KStar (Language α) := ⟨fun l ↦ {x | ∃ L : List (List α), x = L.flatten ∧ ∀ y ∈ L, y ∈ l}⟩
+ join_splitBy
+ length_flatMap
+ length_flatMap'
+ length_flatten'
+ list_flatMap
+ list_flatten
+ map_append_flatMap_perm
+ ne_nil_of_mem_splitBy
+ nil_not_mem_splitBy
+ nodupKeys_flatten
+ nodup_flatMap
+ nodup_flatten
+ ofFin_intCast
+ ofFin_natCast
+ ofFin_neg
+ ofList_flatten
+ prod_flatten
+ ranges_flatten
+ ranges_flatten'
+ rel_flatMap
+ rel_flatten
+ splitBy_nil
+ splitWrtComposition_flatten
+ sublistsAux_eq_flatMap
+ sum_join
+ take_sum_flatten
+ take_sum_flatten'
+ toFin_intCast
+ toFin_natCast
- Quotient.decidableEq
- add_zero
- curry
- curry_apply
- curry_uncurry
- fst_swap
- getElem?_mapIdx
- getElem?_mapIdx_go
- instance : KStar (Language α) := ⟨fun l ↦ {x | ∃ L : List (List α), x = L.join ∧ ∀ y ∈ L, y ∈ l}⟩
- join_filter_isEmpty_eq_false
- join_groupBy
- length_mapIdx
- length_mapIdx_go
- mapIdx_append
- mapIdx_cons
- mapIdx_eq_enum_map
- mapIdx_nil
- map_comp_map
- map_comp_swap
- map_id
- map_id'
- map_map
- map_uncurry_zip_eq_zipWith
- modify_eq_set
- snd_swap
- swap
- swap_inj
- swap_prod_mk
- swap_swap
- swap_swap_eq
- uncurry
- uncurry_apply_pair
- uncurry_curry

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

Comment on lines -12 to +13
info: test.chain_iff.{u_1} {α : Type u_1} (R : α → α → Prop) :
∀ (a : α) (a_1 : List α), List.Chain R a a_1a_1 = [] ∨ ∃ b l, R a b ∧ List.Chain R b l ∧ a_1 = b :: l
info: test.chain_iff.{u_1} {α : Type u_1} (R : α → α → Prop) (a✝ : α) (a✝¹ : List α) :
List.Chain R a✝ a✝¹a✝¹ = [] ∨ ∃ b l, R a b ∧ List.Chain R b l ∧ a✝¹ = b :: l
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kyle has confirmed this change is "by design", and that if downstream tactics want to generate hygienic names they need to do so themselves.

@kim-em kim-em merged commit f8bbd04 into bump/v4.14.0 Oct 31, 2024
31 checks passed
@mathlib-bors mathlib-bors bot deleted the bump/nightly-2024-10-30 branch October 31, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants