-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: liminf and limsup add/mul lemmas in Real #18365
Open
D-Thomine
wants to merge
12
commits into
master
Choose a base branch
from
D-Thomine/limsup_add_mul
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
afd42f2
Order lemmas in Group/Fields
D-Thomine 1325bd8
Swap lemmas
D-Thomine 19ce1a8
Limsup_add lemmas on reals
D-Thomine 8afcf14
Finish mul lemmas
D-Thomine 9584a7b
Delete markers
D-Thomine ae9a0c1
Lengthen file
D-Thomine 00af82f
Minimize imports
D-Thomine 6a8142d
Remove unnecessary assumptions
D-Thomine 946b526
Change names and remove docstrings
D-Thomine e3d178a
Golfing Mathlib.Order.LiminfLimsup
D-Thomine 64ad38a
Break up long proof terms
D-Thomine 1c89dac
Eliminate Icos
D-Thomine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you really think we need those four lemmas? They are all true by definition
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not exactly. This works with
IsBounded
, butIsBoundedUnder
has an additional layer. For instance, something like(hu : f.IsBoundedUnder (· ≤ ·) u); obtain ⟨U, hU⟩ := hu
yields
hU : ∀ᶠ (x : R) in map u f, (fun x1 x2 ↦ x1 ≤ x2) x U
, while(hu : f.IsBoundedUnder (· ≤ ·) u); obtain ⟨U, hU⟩ := hu.eventually_le
yields
hU : ∀ᶠ (x : α) in f, u x ≤ U
, which is more readily useful. There are a couple instances in this new version ofMathlib.Order.LiminfLimsup
where this is useful (see e.g. the proof ofisCoboundedUnder_ge_add
).This is not a big change, but I did not find a simple clean solution, and a basic lemma with a dot notation felt intuitive enough.