Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(AlgebraicGeometry): basic properties of separated morphisms and schemes #17960

Closed
wants to merge 6 commits into from

Conversation

erdOne
Copy link
Member

@erdOne erdOne commented Oct 20, 2024


Open in Gitpod

Copy link

github-actions bot commented Oct 20, 2024

PR summary c9c73b6ad9

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.AlgebraicGeometry.Morphisms.Proper Mathlib.AlgebraicGeometry.Morphisms.Separated 1
Mathlib.CategoryTheory.Limits.Shapes.Pullback.Equalizer 543

Declarations diff

+ IsAffineOpen.preimage
+ IsClosedImmersion.of_comp
+ IsSeparated
+ IsSeparated.comp_iff
+ IsSeparated.hasAffineProperty
+ IsSeparated.of_comp
+ inl_coprodIsoPushout_hom
+ inl_coprodIsoPushout_inv
+ inr_coprodIsoPushout_hom
+ inr_coprodIsoPushout_inv
+ instance (f g : X ⟶ Y) [Y.IsSeparated] : IsClosedImmersion (Limits.equalizer.ι f g)
+ instance (priority := 900) [X.IsSeparated] : IsSeparated f := by
+ instance (priority := 900) {X : Scheme.{u}} [IsAffine X] : X.IsSeparated := ⟨inferInstance⟩
+ instance [IsSeparated f] [IsSeparated g] : IsSeparated (f ≫ g)
+ instance [IsSeparated g] :
+ instance [X.IsSeparated] : IsClosedImmersion (prod.lift (𝟙 X) (𝟙 X)) := by
+ instance {S T : Scheme.{u}} (f : X ⟶ S) (g : Y ⟶ S) (i : S ⟶ T) [IsSeparated i] :
+ isPullback_equalizer_prod
+ isPushout_coequalizer_coprod
+ isSeparated_iff_isClosedImmersion_prod_lift
+ of_comp_isClosedImmersion
+ prodIsoPullback_hom_fst
+ prodIsoPullback_hom_snd
+ prodIsoPullback_inv_fst
+ prodIsoPullback_inv_snd
- instance {Z : Scheme.{u}} (g : Y ⟶ Z) [IsSeparated f] [IsSeparated g] : IsSeparated (f ≫ g)
- isAffineOpen.preimage
- of_comp

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@erdOne erdOne added the t-algebraic-geometry Algebraic geometry label Oct 20, 2024
@erdOne erdOne requested a review from chrisflav October 20, 2024 04:39
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 20, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 20, 2024
@chrisflav chrisflav added the awaiting-author A reviewer has asked the author a question or requested changes label Oct 20, 2024
@erdOne erdOne removed the awaiting-author A reviewer has asked the author a question or requested changes label Oct 20, 2024
Copy link
Collaborator

@chrisflav chrisflav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM! I'll do a zulip-merge in a second :)

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Oct 22, 2024
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 22, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(AlgebraicGeometry): basic properties of separated morphisms and schemes [Merged by Bors] - feat(AlgebraicGeometry): basic properties of separated morphisms and schemes Oct 22, 2024
@mathlib-bors mathlib-bors bot closed this Oct 22, 2024
@mathlib-bors mathlib-bors bot deleted the erd1/separated branch October 22, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-algebraic-geometry Algebraic geometry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants