-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: algebraic properties of LinearMap.compMultilinear
#17932
Conversation
This also demotes `LinearMap.compAlternatingMap` to a plain function, for consistency.
PR summary a644005b86Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
variable (S) in | ||
/-- `LinearMap.compAlternatingMap` as an `S`-linear map. -/ | ||
@[simps] | ||
def compAlternatingMapₗ [Semiring S] [Module S N] [Module S N₂] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have several different conventions about naming of bundled versions of maps. Some day, we should decide what to do about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, I copied MultilinearMap.compLinearMapₗ
Thanks! 🎉 |
This also demotes `LinearMap.compAlternatingMap` to a plain function, for consistency. To make up for this loss, it introduces `LinearMap.compAlternatingMapₗ` as the stronger linear version.
Pull request successfully merged into master. Build succeeded: |
LinearMap.compMultilinear
LinearMap.compMultilinear
This also demotes
LinearMap.compAlternatingMap
to a plain function, for consistency.To make up for this loss, it introduces
LinearMap.compAlternatingMapₗ
as the stronger linear version.