-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore(LinearAlgebra/TensorProduct): fix duplication #17912
Conversation
PR summary aa40cbc5b6Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit> The doc-module for |
Do we do deprecation alias for those? |
I have added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors d+
If you wanted, you could deprecate the *fold
names in favor of subscripts (the reverse of what you've done here) if you'd find them easier to discover. Of course, by ext x y z
works fine anyway, so no one should really need these lemmas...
✌️ yuma-mizuno can now approve this pull request. To approve and merge a pull request, simply reply with |
In my understanding, |
The subscript name was an unintentional product, but it might not be a bad name. |
bors r+ |
Yes this is true,
This was a decision made near the end of mathlib3, for performance. We could try revisiting it now that we have better lean 4 and benchmarking infrastructure. |
bors r+ |
Pull request successfully merged into master. Build succeeded: |
This was unintentionally made in #16776 by myself.