Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(*): replace erw with rw where possible #17703

Closed
wants to merge 5 commits into from

Conversation

Vierkantor
Copy link
Contributor

Go through Mathlib and replace erw calls where rw would also succeed.

This PR is split off from #17638, containing all the changes that the linter suggested.


Open in Gitpod

@Vierkantor Vierkantor added the tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip label Oct 13, 2024
Copy link

PR summary 13ba5856b7

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

Copy link
Collaborator

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by grunweg.

@sgouezel
Copy link
Contributor

bors r+

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Oct 13, 2024
mathlib-bors bot pushed a commit that referenced this pull request Oct 13, 2024
Go through Mathlib and replace `erw` calls where `rw` would also succeed.

This PR is split off from #17638, containing all the changes that the linter suggested.



Co-authored-by: Anne Baanen <[email protected]>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 13, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(*): replace erw with rw where possible [Merged by Bors] - chore(*): replace erw with rw where possible Oct 13, 2024
@mathlib-bors mathlib-bors bot closed this Oct 13, 2024
@mathlib-bors mathlib-bors bot deleted the erw-lint-fixes branch October 13, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer-merge ready-to-merge This PR has been sent to bors. tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants