-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(SeparationQuotient): add missing instances #17239
Conversation
PR summary 96bcdc4fd2
|
File | Base Count | Head Count | Change |
---|---|---|---|
Mathlib.Topology.Algebra.SeparationQuotient | 1060 | 1061 | +1 (+0.09%) |
Import changes for all files
Files | Import difference |
---|---|
Mathlib.Topology.Algebra.SeparationQuotient |
1 |
Declarations diff
+ instContinuousSMul
+ instUniformGroup
+ isOpenQuotientMap_mk
+ postcomp_mkCLM_surjective
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>
The doc-module for script/declarations_diff.sh
contains some details about this script.
theorem postcomp_mkCLM_surjective {L : Type*} [Semiring L] (σ : L →+* K) | ||
(F : Type*) [AddCommMonoid F] [Module L F] [TopologicalSpace F] : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable order looks a little strange here; I'd expect F
to come before σ
, but maybe there's a good reason not to do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My reason was: in "σ
-semilinear maps from E
to F
", σ
comes before F
.
@@ -391,6 +409,14 @@ theorem mk_outCLM (x : SeparationQuotient E) : mk (outCLM K E x) = x := | |||
@[simp] | |||
theorem mk_comp_outCLM : mk ∘ outCLM K E = id := funext (mk_outCLM K) | |||
|
|||
variable {K} in | |||
theorem postcomp_mkCLM_surjective {L : Type*} [Semiring L] (σ : L →+* K) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This lemma isn't a misisng instance; can you mention it in the PR description, or bump it to a later PR?
bors d+
✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with |
bors merge |
Also prove `SeparationQuotient.postcomp_mkCLM_surjective`. I'm going to need these instances and lemmas to generalize `CompleteSpace (E →L[K] F)` to topological vector spaces without assuming that `F` is a Hausdorff space, see #17244.
Pull request successfully merged into master. Build succeeded: |
Also prove `SeparationQuotient.postcomp_mkCLM_surjective`. I'm going to need these instances and lemmas to generalize `CompleteSpace (E →L[K] F)` to topological vector spaces without assuming that `F` is a Hausdorff space, see #17244.
Also prove
SeparationQuotient.postcomp_mkCLM_surjective
.I'm going to need these instances and lemmas
to generalize
CompleteSpace (E →L[K] F)
to topological vector spaceswithout assuming that
F
is a Hausdorff space, see #17244.