Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FieldTheory/Galois): Lemmas of galois theory #16979

Open
wants to merge 26 commits into
base: master
Choose a base branch
from

Conversation

Thmoas-Guan
Copy link
Collaborator

@Thmoas-Guan Thmoas-Guan commented Sep 20, 2024

Add lemmas about Galois extensions, especially the special case of the Galois correspondence.
Co-authored-by: Yongle Hu [email protected] Nailin Guan [email protected] Jingting Wang [email protected]


Open in Gitpod

Copy link

github-actions bot commented Sep 20, 2024

PR summary dac416d611

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ AlgEquiv.restrictNormalHom_apply
+ AlgEquiv.restrictNormalHom_ker
+ Normal.of_conjugate_fixed
+ fixingSubgroup_conjugate_of_map
+ fixingSubgroup_normal_of_isGalois
+ lift_algEquiv
+ normalAutEquivQuotient
+ normalAutEquivQuotient_apply
+ of_fixedField_normal_subgroup

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@Thmoas-Guan Thmoas-Guan added the t-algebra Algebra (groups, rings, fields, etc) label Sep 23, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Sep 24, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Sep 24, 2024
@Thmoas-Guan Thmoas-Guan added the WIP Work in progress label Sep 25, 2024
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) and removed blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) labels Sep 28, 2024
@mathlib4-dependent-issues-bot
Copy link
Collaborator

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Sep 28, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Sep 28, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Sep 29, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Sep 29, 2024
@chrisflav chrisflav added the awaiting-author A reviewer has asked the author a question or requested changes label Sep 29, 2024
@Thmoas-Guan
Copy link
Collaborator Author

This is all the lemmas needed for the incoming PRs #16982 and #16993 , but some is still needed in #16978, do I need to remove the overlaping part or work on this PR first?

@Thmoas-Guan Thmoas-Guan removed the awaiting-author A reviewer has asked the author a question or requested changes label Sep 30, 2024
@faenuccio
Copy link
Collaborator

This is all the lemmas needed for the incoming PRs #16982 and #16993 , but some is still needed in #16978, do I need to remove the overlaping part or work on this PR first?

Do you mean that #16978 depends on this PR? If this is the case, please mark it there and add the blocked-by-other-PR label (add it also to the other two PR's that depend on this one).

@faenuccio faenuccio added the awaiting-author A reviewer has asked the author a question or requested changes label Sep 30, 2024
@Thmoas-Guan
Copy link
Collaborator Author

Thmoas-Guan commented Sep 30, 2024

#16978 can be handled seperately, but should I remove the overlaping part? Because some lemmas in this PR is also used in #16979, I think I should just remove them for now.

@Thmoas-Guan Thmoas-Guan removed the awaiting-author A reviewer has asked the author a question or requested changes label Sep 30, 2024
@faenuccio
Copy link
Collaborator

#16978 can be handled seperately, but should I remove the overlaping part? Because some lemmas in this PR is also used in #16979

Well, if nothing in #16978 needs what is in this PR, then yes, you should remove the overlap: once this PR will be merged the results will be in master and there will be no need to re-add them through #16978. Even better, as soon as this one is merged, when you will update master on #16978, this will import these new lemmas there, so there will be no need to add them manually. All in all, a certain def/lemma should appear in a PR only if

  1. You are trying to add it to master
  2. You need it for the other results of that PR.

@Thmoas-Guan Thmoas-Guan added the awaiting-author A reviewer has asked the author a question or requested changes label Sep 30, 2024
This reverts commit 8bf0b73.
@Thmoas-Guan Thmoas-Guan removed the awaiting-author A reviewer has asked the author a question or requested changes label Sep 30, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 18, 2024
@Thmoas-Guan Thmoas-Guan removed the WIP Work in progress label Oct 19, 2024
@leanprover-community-bot-assistant leanprover-community-bot-assistant removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 19, 2024
Mathlib/FieldTheory/Galois/Basic.lean Outdated Show resolved Hide resolved
Mathlib/FieldTheory/Galois/Basic.lean Outdated Show resolved Hide resolved
Mathlib/FieldTheory/Galois/Basic.lean Outdated Show resolved Hide resolved
Mathlib/FieldTheory/IntermediateField/Basic.lean Outdated Show resolved Hide resolved
Mathlib/FieldTheory/Galois/Basic.lean Outdated Show resolved Hide resolved
Mathlib/FieldTheory/Galois/Basic.lean Outdated Show resolved Hide resolved
Mathlib/FieldTheory/Galois/Basic.lean Outdated Show resolved Hide resolved
Mathlib/FieldTheory/Galois/Basic.lean Outdated Show resolved Hide resolved
Mathlib/FieldTheory/Galois/Basic.lean Outdated Show resolved Hide resolved
Mathlib/FieldTheory/Galois/Basic.lean Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants