-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat (Probability.Kernel): Add definitions and API for Kernel.fst'
and snd'
#15466
base: master
Are you sure you want to change the base?
Conversation
PR summary 61c817e548Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
The names are |
About names: there are Function.Embedding.sectl and MonoidHom.inl. Probably, the former is closer to this case. Also, please ask on Zulip for other suggestions. |
|
||
/-- Define a `Kernel α γ` from a `Kernel (α × β) γ` by taking the comap of `fun a ↦ (a, b)` for | ||
a given `b : β`. -/ | ||
noncomputable def fst' (κ : Kernel (α × β) γ) (b : β) : Kernel α γ := |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you rename that to
noncomputable def fst' (κ : Kernel (α × β) γ) (b : β) : Kernel α γ := | |
noncomputable def domFst (κ : Kernel (α × β) γ) (b : β) : Kernel α γ := |
? Then Kernel.fst
can be renamed to Kernel.codFst
Define a
Kernel α γ
and aKernel β γ
from aKernel (α × β) γ
by taking the comap offun a ↦ (a, b)
andfun b ↦ (a, b)
respectively.Kernel.fst'
andKernel.snd'
.fst'_apply
,fst'_zero
,comap_fst'
,fst'_prodMkLeft
,fst'_prodMkRight
and the equivalent lemmas forsnd'
.IsMarkovKernel
,IsFiniteKernel
,IsSFiniteKernel
andNeZero
.fst'_swapRight
andsnd'_swapRight
.compProd_apply_eq_compProd_snd'
.