[Merged by Bors] - feat: remove lint-style.sh
#15051
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core logic not implemented yet (comes next).
This will be used twice more in the next commit. And use the / notation for file paths, as it's nicer to read.
always regenerate the entire file; no filtering "does the existing exception cover this already, then let me keep it" yet
I need to have a notation of "exception covers new error", but also indicating a preference if the old or the new entry is to be prefered. Write a custom method for this, rather than overloading BEq.
to match the naming convention: all of them are terms of Type, or functions returning such.
Inline it into the workflow file instead: this means lint-style.sh is only calling lint-style.py now.
leanprover-community-mathlib4-bot
added
the
blocked-by-other-PR
PR summary c6b780f490Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for |
leanprover-community-mathlib4-bot
added
the
merge-conflict
leanprover-community-mathlib4-bot
removed
the
merge-conflict
grunweg
force-pushed
the
MR-remove-lintstyle.sh
branch
2 times, most recently
from
f389191
to
fe73a10
Compare
leanprover-community-mathlib4-bot
removed
the
blocked-by-other-PR
grunweg
force-pushed
the
MR-remove-lintstyle.sh
branch
2 times, most recently
from
03a8bbf
to
9b766ce
Compare
grunweg
force-pushed
the
MR-remove-lintstyle.sh
branch
from
9b766ce
to
c6b780f
Compare
1 task
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Aug 15, 2024
In detail, this PR - moves the executable bit check into the .yml files, instead of the shell script - adds a `--fix` flag to `lint-style`, for fixing style errors (when possible) - moves calling `lint-style.py` into `lake exe lint-style`, and - switches the CI workflow to call `lake exe lint-style` instead, and removes `lint-style.sh` Ideally, `lint-style.py` will be completely rewritten in Lean soon, so this calling of an external process is only temporary. Helps with #14539.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
lint-style.shlint-style.sh
|
Thank you for the fast review! |
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
In detail, this PR - moves the executable bit check into the .yml files, instead of the shell script - adds a `--fix` flag to `lint-style`, for fixing style errors (when possible) - moves calling `lint-style.py` into `lake exe lint-style`, and - switches the CI workflow to call `lake exe lint-style` instead, and removes `lint-style.sh` Ideally, `lint-style.py` will be completely rewritten in Lean soon, so this calling of an external process is only temporary. Helps with #14539.
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
In detail, this PR - moves the executable bit check into the .yml files, instead of the shell script - adds a `--fix` flag to `lint-style`, for fixing style errors (when possible) - moves calling `lint-style.py` into `lake exe lint-style`, and - switches the CI workflow to call `lake exe lint-style` instead, and removes `lint-style.sh` Ideally, `lint-style.py` will be completely rewritten in Lean soon, so this calling of an external process is only temporary. Helps with #14539.
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 12, 2024
In detail, this PR - moves the executable bit check into the .yml files, instead of the shell script - adds a `--fix` flag to `lint-style`, for fixing style errors (when possible) - moves calling `lint-style.py` into `lake exe lint-style`, and - switches the CI workflow to call `lake exe lint-style` instead, and removes `lint-style.sh` Ideally, `lint-style.py` will be completely rewritten in Lean soon, so this calling of an external process is only temporary. Helps with #14539.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In detail, this PR
--fixflag tolint-style, for fixing style errors (when possible)lint-style.pyintolake exe lint-style, andlake exe lint-styleinstead, and removeslint-style.shIdeally,
lint-style.pywill be completely rewritten in Lean soon, so this calling of an external process is only temporary.Helps with #14539.