Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(Combinatorics/SimpleGraph): define
edist
and rewritedist
#14582[Merged by Bors] - feat(Combinatorics/SimpleGraph): define
edist
and rewritedist
#14582Changes from 8 commits
0d28e97
401005c
353eb9c
034f3b8
1996e74
ff344f9
033d3d9
aff9421
fa54c4a
0a60d79
7024912
7d8a20b
f59304b
183bcdd
4bf5037
2ebae9c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't need connectedness since we're using edist!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's probably not worth developing all this theory, but it occurred to me that we could pull back infinity to Walk to have "extended walks", along with the "does not exist" walk. Then
edist_triangle
could be proved without any cases, because it's already been done inEWalk.length_append
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a great idea! I'll keep it in mind to potentially work on.
I think it would be nicer to move
Walk
s fromConnectivity.lean
into their own file (in theConnectivity
folder) before attempting that, what do you think?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that change does sound valuable - Reachable and Connected can be in Connectivity.lean; Walks and Paths can be in Walk.lean
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#15171 does this.