Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore (Algebra.Order.Ring.Defs): split file and unbundle results #14393

Closed
wants to merge 17 commits into from

Conversation

mattrobball
Copy link
Collaborator

@mattrobball mattrobball commented Jul 3, 2024

All of the theorems in Algebra.Order.Ring.Defs currently take bundled ordered algebraic typeclasses, eg OrderedSemiring as paramaters unecessarily. We unbundle the results keeping the algebra and order data/theorems separate and adding the mixin compatbility typeclasses as needed and place the theorems in Algebra.Order.Ring.Unbundled.Basic. As Algebra.Order.Ring.Defs and upstream resuls already allow us to pass from bundled classes to unbundled classes appropriately, we lose no uusability by doing this. We lessen dependecies and gain future flexibility.


Open in Gitpod

Copy link

github-actions bot commented Jul 3, 2024

PR summary 99b3831c9d

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Too many changes (2838)!

Declarations diff

+ instance : Monoid { x : R // 0 < x }
+ instance : One { x : R // 0 < x }
- instance [Nontrivial R] : Monoid { x : R // 0 < x }
- instance [Nontrivial R] : One { x : R // 0 < x }
- min_mul_min_le_mul_min_min

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 6, 2024
@mattrobball mattrobball added the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Jul 7, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Jul 7, 2024
@mattrobball mattrobball added the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Jul 8, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Jul 8, 2024
@mattrobball
Copy link
Collaborator Author

Why is this fighting the blocked-by-other-pr label?!

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 16, 2024
@kim-em
Copy link
Contributor

kim-em commented Jul 16, 2024

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jul 16, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jul 16, 2024
)

All of the theorems in `Algebra.Order.Ring.Defs` currently take bundled ordered algebraic typeclasses, eg `OrderedSemiring` as paramaters unecessarily. We unbundle the results keeping the algebra and order data/theorems separate and adding the mixin compatbility typeclasses as needed and place the theorems in `Algebra.Order.Ring.Unbundled.Basic`. As `Algebra.Order.Ring.Defs` and upstream resuls already allow us to pass from bundled classes to unbundled classes appropriately, we lose no uusability by doing this. We lessen dependecies and gain future flexibility.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 16, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore (Algebra.Order.Ring.Defs): split file and unbundle results [Merged by Bors] - chore (Algebra.Order.Ring.Defs): split file and unbundle results Jul 16, 2024
@mathlib-bors mathlib-bors bot closed this Jul 16, 2024
@mathlib-bors mathlib-bors bot deleted the mrb/split_algebra_order_ring_defs branch July 16, 2024 23:35
@YaelDillies
Copy link
Collaborator

Why is this fighting the blocked-by-other-pr label?!

Probably you had the syntax slightly wrong. I'm surprised this was merged without a

!bench

@mattrobball
Copy link
Collaborator Author

http://speed.lean-fro.org/mathlib4/run-detail/d4cc9472-dddb-4457-8316-df3d0425fded

@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants