-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore (Algebra.Order.Ring.Defs): split file and unbundle results #14393
Conversation
PR summary 99b3831c9dImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
Why is this fighting the |
bors merge |
) All of the theorems in `Algebra.Order.Ring.Defs` currently take bundled ordered algebraic typeclasses, eg `OrderedSemiring` as paramaters unecessarily. We unbundle the results keeping the algebra and order data/theorems separate and adding the mixin compatbility typeclasses as needed and place the theorems in `Algebra.Order.Ring.Unbundled.Basic`. As `Algebra.Order.Ring.Defs` and upstream resuls already allow us to pass from bundled classes to unbundled classes appropriately, we lose no uusability by doing this. We lessen dependecies and gain future flexibility.
Pull request successfully merged into master. Build succeeded: |
Probably you had the syntax slightly wrong. I'm surprised this was merged without a !bench |
All of the theorems in
Algebra.Order.Ring.Defs
currently take bundled ordered algebraic typeclasses, egOrderedSemiring
as paramaters unecessarily. We unbundle the results keeping the algebra and order data/theorems separate and adding the mixin compatbility typeclasses as needed and place the theorems inAlgebra.Order.Ring.Unbundled.Basic
. AsAlgebra.Order.Ring.Defs
and upstream resuls already allow us to pass from bundled classes to unbundled classes appropriately, we lose no uusability by doing this. We lessen dependecies and gain future flexibility.ExistsAddOfLE
andExistsMulOfLE
#14390