-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(FiberedCategory/HasFibers): define HasFibers class #13611
base: master
Are you sure you want to change the base?
Conversation
…-community/mathlib4 into fiberedcategory_fiber
…prover-community/mathlib4 into fiberedcategories_hasfibers
The |
This is what a clivage is right? If so I think we have discussed it. I think the name |
…lib4 into fiberedcategories_hasfibers
I've removed awaiting-author for now, or do you mean that I should add |
@[default_instance] | ||
instance canonical (p : 𝒳 ⥤ 𝒮) : HasFibers p where |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should not be an instance, only a def
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then will it still work as a "default instance"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure exactly what default_instance
do. I think we should remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My opinion is that I would not like to have default instances flying around... If we need a HasFibers
instance in order to prove a statement (which does not already involve a HasFibers
), then we may invoke this canonical
in order to make the argument work. Otherwise, [HasFibers p]
should be a variable.
This PR is already long enough :-) |
Co-authored-by: Joël Riou <[email protected]>
We define a class
HasFibers p
for a given functorp : 𝒳 ⥤ 𝒮
. The point of this is to give the user the option to supply their own fiber categories, as often the standard fibers will not be definitionally the same as the (equivalent) categories one is interested in.Co-authored-by: Paul Lezeau [email protected]
This is the final PR in a sequence of PRs developing the theory of fibered categories that I will make for now. I will wait for the reviewing to catch up before I start working on more of these again, so as to not create too big of a backlog.