Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: add a version of Ideal.associatesEquivIsPrincipal for generators that are non-zero-divisors #12780

Closed
wants to merge 13 commits into from
Closed

[Merged by Bors] - feat: add a version of Ideal.associatesEquivIsPrincipal for generators that are non-zero-divisors #12780

wants to merge 13 commits into from

Conversation

xroblot
Copy link
Collaborator

@xroblot xroblot commented May 9, 2024 •
edited
Loading

This PR defines the following equiv:

def Ideal.associatesNonZeroDivisorsEquivIsPrincipal : 
    Associates R⁰ ≃ {I : (Ideal R)⁰ // IsPrincipal (I : Ideal R)}

and also a MulEquiv version.

Open in Gitpod

@xroblot xroblot added awaiting-CI t-algebra Algebra (groups, rings, fields, etc) labels May 9, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label May 9, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) labels May 11, 2024
@xroblot xroblot mentioned this pull request May 11, 2024
Closed
3 tasks
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) and removed blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) labels May 21, 2024
@xroblot xroblot requested a review from faenuccio May 23, 2024 13:17
@faenuccio faenuccio added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review labels May 24, 2024
@xroblot xroblot mentioned this pull request May 24, 2024
Closed
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label May 25, 2024
@xroblot xroblot added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes labels May 25, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label May 30, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

This PR/issue depends on:

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label May 30, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label May 30, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 10, 2024
@github-actions GitHub Actions
Copy link

PR summary 5efc615858

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Ideal.span_singleton_nonZeroDivisors
+ associatesNonZeroDivisorsEquivIsPrincipal
+ associatesNonZeroDivisorsEquivIsPrincipal_apply
+ associatesNonZeroDivisorsEquivIsPrincipal_coe
+ associatesNonZeroDivisorsEquivIsPrincipal_map_one
+ associatesNonZeroDivisorsEquivIsPrincipal_mul
+ associatesNonZeroDivisorsMulEquivIsPrincipal
+ isPrincipalNonZeroDivisorsSubmonoid

You can run this locally as follows 
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@riccardobrasca
Copy link
Member

Thanks!

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 11, 2024

✌️ xroblot can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 11, 2024
@xroblot
Copy link
Collaborator Author

xroblot commented Jul 11, 2024

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Jul 11, 2024
@xroblot
feat: add a version of Ideal.associatesEquivIsPrincipal for generat…
25864f5 
…ors that are non-zero-divisors (#12780)

This PR defines the following equiv: 
```lean
def Ideal.associatesNonZeroDivisorsEquivIsPrincipal : 
    Associates R⁰ ≃ {I : (Ideal R)⁰ // IsPrincipal (I : Ideal R)}
```
and also a `MulEquiv` version.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 11, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: add a version of Ideal.associatesEquivIsPrincipal for generators that are non-zero-divisors [Merged by Bors] - feat: add a version of Ideal.associatesEquivIsPrincipal for generators that are non-zero-divisors Jul 11, 2024
@mathlib-bors mathlib-bors bot closed this Jul 11, 2024
@mathlib-bors mathlib-bors bot deleted the xfr-isprincipalequiv_nzd branch July 11, 2024 11:09
@adomani adomani mentioned this pull request Aug 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riccardobrasca riccardobrasca riccardobrasca approved these changes

@faenuccio faenuccio faenuccio left review comments

Assignees
No one assigned
Labels
delegated t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@xroblot @leanprover-community-mathlib4-bot @riccardobrasca @faenuccio @kim-em @YaelDillies