Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(lint-style): various small clean-ups #12596

Closed
wants to merge 7 commits into from
Closed

refactor(lint-style): various small clean-ups #12596

wants to merge 7 commits into from

Commits on May 11, 2024

  1. chore: alphabetise standard imports

    @grunweg
    grunweg committed May 11, 2024
    Configuration menu
    Copy the full SHA
    6c35dc4 View commit details
    Browse the repository at this point in the history

  2. refactor(lint-style): reduce duplication in format_errors

    @grunweg
    grunweg committed May 11, 2024
    Configuration menu
    Copy the full SHA
    bbaf01c View commit details
    Browse the repository at this point in the history

  3. Convert the possible errors to an enum. 

    This allows simplifying format_errors further:
for an enum value v, v.name outputs the corresponding variant name.
    @grunweg
    grunweg committed May 11, 2024
    Configuration menu
    Copy the full SHA
    03a6b2a View commit details
    Browse the repository at this point in the history

  4. Clean up exception parsing: truly support all errors.

    @grunweg
    grunweg committed May 11, 2024
    Configuration menu
    Copy the full SHA
    50e25e3 View commit details
    Browse the repository at this point in the history

  5. Ensure error numbers are unique.

    @grunweg
    grunweg committed May 11, 2024
    Configuration menu
    Copy the full SHA
    eafb953 View commit details
    Browse the repository at this point in the history

  6. Extract the error message into a separate method, and move next to th… 

    …e error enum.
    @grunweg
    grunweg committed May 11, 2024
    Configuration menu
    Copy the full SHA
    4ab0d78 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. chore: remove ERR_ prefix from Error variant names

    @grunweg
    grunweg committed May 15, 2024
    Configuration menu
    Copy the full SHA
    2c3e9a5 View commit details
    Browse the repository at this point in the history