Skip to content

Commit

Permalink
Cargo-cult fix from #16303
Browse files Browse the repository at this point in the history
  • Loading branch information
@grunweg
grunweg committed Aug 30, 2024
1 parent eb24240 commit 567eeb3
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 8 deletions.
7 changes: 5 additions & 2 deletions .github/workflows/bors.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,13 @@ jobs:
- name: "check the formatting of the PR title and for missing or inconsistent labels"
# TODO: skip this check if the PR is in draft stage!
shell: bash # just in case
run: |

Check failure on line 78 in .github/workflows/bors.yml

View workflow job for this annotation

GitHub Actions / actionlint 

shellcheck reported issue in this script: SC2086:info:5:6: Double quote to prevent globbing and word splitting

Check failure on line 78 in .github/workflows/bors.yml

View workflow job for this annotation

GitHub Actions / actionlint 

shellcheck reported issue in this script: SC2086:info:6:36: Double quote to prevent globbing and word splitting

Check failure on line 78 in .github/workflows/bors.yml

View workflow job for this annotation

GitHub Actions / actionlint 

"github.event.pull_request.title" is potentially untrusted. avoid using it directly in inline scripts. instead, pass it through an environment variable. see https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions for more details
set -eo pipefail
title=${{github.event.pull_request.title}}
label_names=${{github.event.pull_request.labels[*].name}}
title="${{github.event.pull_request.title}}"
echo $title
label_names=$(echo "${{ toJson(github.event.pull_request.labels) }}" | jq -r '.[].name')
echo $label_names
lake exe check-title-labels $title $label_names
- name: Install bibtool
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,9 @@ jobs:
shell: bash # just in case
run: |

Check failure on line 85 in .github/workflows/build.yml

View workflow job for this annotation

GitHub Actions / actionlint 

shellcheck reported issue in this script: SC2086:info:5:6: Double quote to prevent globbing and word splitting

Check failure on line 85 in .github/workflows/build.yml

View workflow job for this annotation

GitHub Actions / actionlint 

shellcheck reported issue in this script: SC2086:info:6:36: Double quote to prevent globbing and word splitting

Check failure on line 85 in .github/workflows/build.yml

View workflow job for this annotation

GitHub Actions / actionlint 

"github.event.pull_request.title" is potentially untrusted. avoid using it directly in inline scripts. instead, pass it through an environment variable. see https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions for more details
set -eo pipefail
title=${{github.event.pull_request.title}}
title="${{github.event.pull_request.title}}"
echo $title
label_names=${{github.event.pull_request.labels[*].name}}
label_names=$(echo "${{ toJson(github.event.pull_request.labels) }}" | jq -r '.[].name')
echo $label_names
lake exe check-title-labels $title $label_names
Expand Down
7 changes: 5 additions & 2 deletions .github/workflows/build.yml.in
View file
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,13 @@ jobs:

- name: "check the formatting of the PR title and for missing or inconsistent labels"
# TODO: skip this check if the PR is in draft stage!
shell: bash # just in case
run: |
set -eo pipefail
title=${{github.event.pull_request.title}}
label_names=${{github.event.pull_request.labels[*].name}}
title="${{github.event.pull_request.title}}"
echo $title
label_names=$(echo "${{ toJson(github.event.pull_request.labels) }}" | jq -r '.[].name')
echo $label_names
lake exe check-title-labels $title $label_names

- name: Install bibtool
Expand Down
7 changes: 5 additions & 2 deletions .github/workflows/build_fork.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,13 @@ jobs:
- name: "check the formatting of the PR title and for missing or inconsistent labels"
# TODO: skip this check if the PR is in draft stage!
shell: bash # just in case
run: |

Check failure on line 82 in .github/workflows/build_fork.yml

View workflow job for this annotation

GitHub Actions / actionlint 

shellcheck reported issue in this script: SC2086:info:5:6: Double quote to prevent globbing and word splitting

Check failure on line 82 in .github/workflows/build_fork.yml

View workflow job for this annotation

GitHub Actions / actionlint 

shellcheck reported issue in this script: SC2086:info:6:36: Double quote to prevent globbing and word splitting

Check failure on line 82 in .github/workflows/build_fork.yml

View workflow job for this annotation

GitHub Actions / actionlint 

"github.event.pull_request.title" is potentially untrusted. avoid using it directly in inline scripts. instead, pass it through an environment variable. see https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions for more details
set -eo pipefail
title=${{github.event.pull_request.title}}
label_names=${{github.event.pull_request.labels[*].name}}
title="${{github.event.pull_request.title}}"
echo $title
label_names=$(echo "${{ toJson(github.event.pull_request.labels) }}" | jq -r '.[].name')
echo $label_names
lake exe check-title-labels $title $label_names
- name: Install bibtool
Expand Down

0 comments on commit 567eeb3

Please sign in to comment.