Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET 8 #213

Merged
merged 15 commits into from
Jul 2, 2024
Merged

.NET 8 #213

merged 15 commits into from
Jul 2, 2024

Conversation

TheTedder
Copy link
Contributor

I took the liberty of upgrading to .NET 8 since .NET 7 is out of support. I also updated almost all of our dependencies. This is bound to break something so it's a good idea to test this heavily. The default placeholder JWT private key had to be increased in length because it didn't have enough entropy or something.

@TheTedder TheTedder marked this pull request as ready for review June 25, 2024 17:58
@TheTedder TheTedder requested a review from a team as a code owner June 25, 2024 17:58
@zysim
Copy link
Collaborator

zysim commented Jul 1, 2024

  1. Gotta allow anonymous fetching of Categories. We really don't need to be authorised for that
  2. How do you generate openapi.json again? It's been so long

Also I've done some testing of the API. Not like "running tests" testing, but calling the API itself, locally. Able to register a new user, log in/out, and create leaderboards and categories, but only if we're authorised. So far so good.

All tests pass, too.

@zysim
Copy link
Collaborator

zysim commented Jul 1, 2024

Will do more testing tomorrow

@TheTedder
Copy link
Contributor Author

TheTedder commented Jul 1, 2024

  1. Gotta allow anonymous fetching of Categories. We really don't need to be authorised for that

This PR doesn't touch category logic. Also, we're gonna go through and change all that anyway after account-related flows are done.

@zysim
Copy link
Collaborator

zysim commented Jul 2, 2024

  1. Gotta allow anonymous fetching of Categories. We really don't need to be authorised for that

This PR doesn't touch category logic. Also, we're gonna go through and change all that anyway after account-related flows are done.

Yeah that's fair. I'll add a ticket for that if there isn't one, already.

@zysim
Copy link
Collaborator

zysim commented Jul 2, 2024

Yeah the backend works. Only problems are some action behaviours. I'll list them out in a separate ticket.

#214

@zysim zysim merged commit 8977552 into leaderboardsgg:main Jul 2, 2024
1 check passed
@TheTedder TheTedder deleted the dotnet-8 branch July 10, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants